refactor findTagFromReleases

purely a sytlistic choice to not have to pre-declare the _release variable,
and not have to check using `typeof _release === "string"` when detecting
a found release
This commit is contained in:
Ryan Waskiewicz 2025-04-16 12:14:31 -04:00
parent b585fed8fa
commit b60e13504f
No known key found for this signature in database
GPG key ID: 5CD9C00A4F498A18

View file

@ -347,19 +347,17 @@ export async function findTagFromReleases(
owner: string,
repo: string,
tag: string,
) {
let _release: Release | undefined;
for await (const response of releaser.allReleases({
): Promise<Release | undefined> {
for await (const { data: releases } of releaser.allReleases({
owner,
repo,
})) {
_release = response.data.find((release) => release.tag_name === tag);
// detect if we found a release - note that a draft release tag may be an empty string
if (typeof _release !== "undefined") {
break;
const release = releases.find((release) => release.tag_name === tag);
if (release) {
return release;
}
}
return _release;
return undefined;
}
async function createRelease(