From b60e13504f81fc41afdf88a37ca3ccdfaf2cadd9 Mon Sep 17 00:00:00 2001
From: Ryan Waskiewicz <Ryan.Waskiewicz@abbyy.com>
Date: Wed, 16 Apr 2025 12:14:31 -0400
Subject: [PATCH] refactor findTagFromReleases

purely a sytlistic choice to not have to pre-declare the _release variable,
and not have to check using `typeof _release === "string"` when detecting
a found release
---
 src/github.ts | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/github.ts b/src/github.ts
index 35af897..990b291 100644
--- a/src/github.ts
+++ b/src/github.ts
@@ -347,19 +347,17 @@ export async function findTagFromReleases(
   owner: string,
   repo: string,
   tag: string,
-) {
-  let _release: Release | undefined;
-  for await (const response of releaser.allReleases({
+): Promise<Release | undefined> {
+  for await (const { data: releases } of releaser.allReleases({
     owner,
     repo,
   })) {
-    _release = response.data.find((release) => release.tag_name === tag);
-    // detect if we found a release - note that a draft release tag may be an empty string
-    if (typeof _release !== "undefined") {
-      break;
+    const release = releases.find((release) => release.tag_name === tag);
+    if (release) {
+      return release;
     }
   }
-  return _release;
+  return undefined;
 }
 
 async function createRelease(