From e58da9f08250bcb776d91f9e44de50dd79f2126e Mon Sep 17 00:00:00 2001
From: frostime <frostime@foxmail.com>
Date: Sat, 16 Aug 2025 16:28:25 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix=20some=20svelte=20bugs?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/hello.svelte | 18 +++++++++---------
 src/index.ts     | 46 +++++++++++++++++++++++-----------------------
 2 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/src/hello.svelte b/src/hello.svelte
index 967c7f6..23353c7 100644
--- a/src/hello.svelte
+++ b/src/hello.svelte
@@ -8,35 +8,35 @@
 -->
 <script lang="ts">
     import { onDestroy, onMount } from "svelte";
-    import { version, sql as query } from "@/api";
+    // import { version } from "@/api";
     import { showMessage, fetchPost, Protyle } from "siyuan";
 
     export let app;
+    export let blockID: string;
 
     let time: string = "";
-    let ver: string = "";
 
     let divProtyle: HTMLDivElement;
     let protyle: any;
-    let blockID: string = '';
 
     onMount(async () => {
-        ver = await version();
+        // ver = await version();
         fetchPost("/api/system/currentTime", {}, (response) => {
             time = new Date(response.data).toString();
         });
-        protyle = await initProtyle();
+        if (blockID) {
+            protyle = await initProtyle();
+        } else {
+            divProtyle.innerHTML = "Please open a document first";
+        }
     });
 
     onDestroy(() => {
         showMessage("Hello panel closed");
-        protyle.destroy();
+        protyle?.destroy();
     });
 
     async function initProtyle() {
-        let sql = "SELECT * FROM blocks ORDER BY RANDOM () LIMIT 1;";
-        let blocks: Block[] = await query(sql);
-        blockID = blocks[0].id;
         return new Protyle(app, divProtyle, {
             blockId: blockID
         });
diff --git a/src/index.ts b/src/index.ts
index 4777328..614e0a4 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -80,15 +80,17 @@ export default class PluginSample extends Plugin {
 </symbol>`);
 
         let tabDiv = document.createElement("div");
-        new HelloExample({
-            target: tabDiv,
-            props: {
-                app: this.app,
-            }
-        });
+        let app = null;
         this.custom = this.addTab({
             type: TAB_TYPE,
             init() {
+                app = new HelloExample({
+                    target: tabDiv,
+                    props: {
+                        app: this.app,
+                        blockID: this.data.blockID
+                    }
+                });
                 this.element.appendChild(tabDiv);
                 console.log(this.element);
             },
@@ -96,6 +98,7 @@ export default class PluginSample extends Plugin {
                 console.log("before destroy tab:", TAB_TYPE);
             },
             destroy() {
+                app?.$destroy();
                 console.log("destroy tab:", TAB_TYPE);
             }
         });
@@ -464,20 +467,7 @@ export default class PluginSample extends Plugin {
     }
 
     private showDialog() {
-        // let dialog = new Dialog({
-        //     title: `SiYuan ${Constants.SIYUAN_VERSION}`,
-        //     content: `<div id="helloPanel" class="b3-dialog__content"></div>`,
-        //     width: this.isMobile ? "92vw" : "720px",
-        //     destroyCallback() {
-        //         // hello.$destroy();
-        //     },
-        // });
-        // new HelloExample({
-        //     target: dialog.element.querySelector("#helloPanel"),
-        //     props: {
-        //         app: this.app,
-        //     }
-        // });
+        const docId = this.getEditor().protyle.block.rootID;
         svelteDialog({
             title: `SiYuan ${Constants.SIYUAN_VERSION}`,
             width: this.isMobile ? "92vw" : "720px",
@@ -486,6 +476,7 @@ export default class PluginSample extends Plugin {
                     target: container,
                     props: {
                         app: this.app,
+                        blockID: docId
                     }
                 });
             }
@@ -498,11 +489,19 @@ export default class PluginSample extends Plugin {
         });
         menu.addItem({
             icon: "iconSettings",
-            label: "Open Setting",
+            label: "Open SiYuan Setting",
+            click: () => {
+                openSetting(this.app);
+            }
+        });
+        menu.addItem({
+            icon: "iconSettings",
+            label: "Open Plugin Setting",
             click: () => {
                 this.openSetting();
             }
         });
+        menu.addSeparator();
         menu.addItem({
             icon: "iconDrag",
             label: "Open Attribute Panel",
@@ -532,7 +531,7 @@ export default class PluginSample extends Plugin {
         if (!this.isMobile) {
             menu.addItem({
                 icon: "iconFace",
-                label: "Open Custom Tab",
+                label: "Open Custom Tab(open doc first)",
                 click: () => {
                     const tab = openTab({
                         app: this.app,
@@ -540,7 +539,8 @@ export default class PluginSample extends Plugin {
                             icon: "iconFace",
                             title: "Custom Tab",
                             data: {
-                                text: platformUtils.isHuawei() ? "Hello, Huawei!" : "This is my custom tab",
+                                // text: platformUtils.isHuawei() ? "Hello, Huawei!" : "This is my custom tab",
+                                blockID: this.getEditor().protyle.block.rootID,
                             },
                             id: this.name + TAB_TYPE
                         },