* fix(release): break when draft release is found
when a release with the desired tag_name is found, break out of the loop
that looks for it. this prevents the case where accidentally overwrite a
detected release on successive iterations of the for loop
fixes: #602
* include built output
* add tests for finding tag from releases
add tests for updated functionality to break when we find a release.
the logic has been extracted into its own function, to make testing
simpler by avoiding over mocking/stubbing of network calls that would
create or update a release.
the tests that were added use jest's describe/it blocks, but use node's
assert function to align with other tests. there isn't any prior art for
mocking function calls in the codebase, so for now we use simple promises
in "mock" objects that adhere to the Releaser interface
* refactor findTagFromReleases
purely a sytlistic choice to not have to pre-declare the _release variable,
and not have to check using `typeof _release === "string"` when detecting
a found release
* reset dist/index.js to master
* update impl after merge with master
* update dist
* fix: use readableWebStream() to stream asset contents
This allows the uploads to finish without mismatched Content-Length,
likely because the original method implied a wrong body encoding or
something similar. Unfortunately a GitHub server API mock was not
readily available so I had to test manually with a barebones repository.
Fixes: #555Fixes: #556
Signed-off-by: WANG Xuerui <git@xen0n.name>
* feat: log when each asset is successfully uploaded
Signed-off-by: WANG Xuerui <git@xen0n.name>
* build: refresh dist
Signed-off-by: WANG Xuerui <git@xen0n.name>
* style: format with prettier
Signed-off-by: WANG Xuerui <git@xen0n.name>
---------
Signed-off-by: WANG Xuerui <git@xen0n.name>
Previously all assets were being read synchronously into memory, making
the action unsuitable for releasing very large assets. Because the
client library allows stream body inputs (it just forwards it to the
underlying `fetch` implementation), just do it.
The idea is also suggested by @enumag in
https://github.com/softprops/action-gh-release/issues/353#issuecomment-1793865790.
Fixes: #353
Signed-off-by: WANG Xuerui <git@xen0n.name>
