diff --git a/README.md b/README.md index 9a67d7b..e2b0abf 100644 --- a/README.md +++ b/README.md @@ -164,6 +164,7 @@ jobs: body_path: ${{ github.workflow }}-CHANGELOG.txt env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_REPOSITORY: my_gh_org/my_gh_repo ``` ### 💅 Customizing @@ -181,7 +182,6 @@ The following are optional as `step.with` keys | `files` | String | Newline-delimited globs of paths to assets to upload for release | | `name` | String | Name of the release. defaults to tag name | | `tag_name` | String | Name of a tag. defaults to `github.ref` | -| `repository` | String | Name of a target repository in `/` format. defaults to the current repository | | `fail_on_unmatched_files` | Boolean | Indicator of whether to fail if any of the `files` globs match nothing | | `target_commitish` | String | Commitish value that determines where the Git tag is created from. Can be any branch or commit SHA. | @@ -194,6 +194,7 @@ The following outputs can be accessed via `${{ steps..outputs }}` from | Name | Type | Description | |-------------|---------|-----------------------------------------------------------------| | `url` | String | Github.com URL for the release | +| `upload_url`| String | URL for uploading assets to the release | #### environment variables @@ -203,6 +204,7 @@ The following are *required* as `step.env` keys | Name | Description | |----------------|--------------------------------------| | `GITHUB_TOKEN` | GITHUB_TOKEN as provided by `secrets`| +| `GITHUB_REPOSITORY` | Name of a target repository in `/` format. defaults to the current repository| > **⚠️ Note:** This action was previously implemented as a Docker container, limiting its use to GitHub Actions Linux virtual environments only. With recent releases, we now support cross platform usage. You'll need to remove the `docker://` prefix in these versions diff --git a/__tests__/util.test.ts b/__tests__/util.test.ts index 6bc4abe..b351c47 100644 --- a/__tests__/util.test.ts +++ b/__tests__/util.test.ts @@ -60,9 +60,9 @@ describe("util", () => { }) ); }); - it("defaults to body when both body and body path are provided", () => { + it("defaults to body path when both body and body path are provided", () => { assert.equal( - "foo", + "bar", releaseBody({ github_ref: "", github_repository: "", diff --git a/action.yml b/action.yml index a076799..7d0e8c6 100644 --- a/action.yml +++ b/action.yml @@ -38,6 +38,8 @@ env: outputs: url: description: 'URL to the Release HTML Page' + upload_url: + description: 'URL for uploading assets to the release' runs: using: 'node12' main: 'dist/index.js' diff --git a/src/main.ts b/src/main.ts index 47ae8b8..df7264e 100644 --- a/src/main.ts +++ b/src/main.ts @@ -55,6 +55,7 @@ async function run() { } console.log(`🎉 Release ready at ${rel.html_url}`); setOutput("url", rel.html_url); + setOutput("upload_url", rel.upload_url); } catch (error) { setFailed(error.message); } diff --git a/src/util.ts b/src/util.ts index 17e76a6..2d4df71 100644 --- a/src/util.ts +++ b/src/util.ts @@ -20,9 +20,9 @@ export interface Config { export const releaseBody = (config: Config): string | undefined => { return ( - config.input_body || (config.input_body_path && - readFileSync(config.input_body_path).toString("utf8")) + readFileSync(config.input_body_path).toString("utf8")) || + config.input_body ); };