fix: revert fs:readableWebStream change (#632)

* Revert "fix: fix file closing issue (#629)"

This reverts commit 07a2257003.

* fix: revert `fh.readableWebStream` change

Signed-off-by: Rui Chen <rui@chenrui.dev>

---------

Signed-off-by: Rui Chen <rui@chenrui.dev>

.github/dependabot.yml

@@ -12,13 +12,9 @@ updates:
       - dependency-name: node-fetch
         versions:
           - ">=3.0.0"
-      # ignore mime and @types/mime per https://github.com/softprops/action-gh-release/pull/475
+      - dependency-name: "@types/node"
-      - dependency-name: mime
         versions:
-          - ">=4.0.0"
+          - ">=22.0.0"
-      - dependency-name: "@types/mime"
-        versions:
-          - ">=4.0.0"
     commit-message:
       prefix: "chore(deps)"
   - package-ecosystem: github-actions

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "action-gh-release",
-  "version": "2.2.2",
+  "version": "2.3.1",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "action-gh-release",
-      "version": "2.2.2",
+      "version": "2.3.1",
       "dependencies": {
         "@actions/core": "^1.11.1",
         "@actions/github": "^6.0.1",
@@ -18,7 +18,7 @@
       "devDependencies": {
         "@types/glob": "^8.1.0",
         "@types/mime-types": "^3.0.1",
-        "@types/node": "^22.15.21",
+        "@types/node": "^20.17.32",
         "@vercel/ncc": "^0.38.3",
         "@vitest/coverage-v8": "^3.1.4",
         "prettier": "3.5.3",
@@ -1512,9 +1512,9 @@
       "dev": true
     },
     "node_modules/@types/node": {
-      "version": "22.15.21",
+      "version": "20.19.0",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-22.15.21.tgz",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-20.19.0.tgz",
-      "integrity": "sha512-EV/37Td6c+MgKAbkcLG6vqZ2zEYHD7bvSrzqqs2RIhbA6w3x+Dqz8MZM3sP6kGTeLrdoOgKZe+Xja7tUB2DNkQ==",
+      "integrity": "sha512-hfrc+1tud1xcdVTABC2JiomZJEklMcXYNTVtZLAeqTVWD+qL5jkHKT+1lOtqDdGxt+mB53DTtiz673vfjU8D1Q==",
       "dev": true,
       "license": "MIT",
       "dependencies": {

package.json

@@ -32,7 +32,7 @@
   "devDependencies": {
     "@types/glob": "^8.1.0",
     "@types/mime-types": "^3.0.1",
-    "@types/node": "^22.15.21",
+    "@types/node": "^20.17.32",
     "@vercel/ncc": "^0.38.3",
     "@vitest/coverage-v8": "^3.1.4",
     "prettier": "3.5.3",

src/github.ts

@@ -1,9 +1,9 @@
 import { GitHub } from "@actions/github/lib/utils";
-import { Config, isTag, releaseBody, alignAssetName } from "./util";
 import { statSync } from "fs";
 import { open } from "fs/promises";
 import { lookup } from "mime-types";
 import { basename } from "path";
+import { alignAssetName, Config, isTag, releaseBody } from "./util";
 
 type GitHub = InstanceType<typeof GitHub>;
 
@@ -180,7 +180,6 @@ export const upload = async (
   endpoint.searchParams.append("name", name);
   const fh = await open(path);
   try {
-    const stream = fh.readableWebStream();
     const resp = await github.request({
       method: "POST",
       url: endpoint.toString(),
@@ -189,7 +188,7 @@ export const upload = async (
         "content-type": mime,
         authorization: `token ${config.github_token}`,
       },
-      data: stream,
+      data: fh.readableWebStream({ type: "bytes" }),
     });
     const json = resp.data;
     if (resp.status !== 201) {
@@ -202,7 +201,7 @@ export const upload = async (
     console.log(`✅ Uploaded ${name}`);
     return json;
   } finally {
-    await fh.close().catch(() => {});
+    await fh.close();
   }
 };
 

src/util.ts

@@ -91,10 +91,7 @@ const parseMakeLatest = (
 export const paths = (patterns: string[]): string[] => {
   return patterns.reduce((acc: string[], pattern: string): string[] => {
     return acc.concat(
-      glob
+      glob.sync(pattern).filter((path) => statSync(path).isFile()),
-        .sync(pattern)
-        .filter((path) => statSync(path).isFile())
-        .map((path) => path.replace(/\\/g, "/")),
     );
   }, []);
 };