mirrors/action-gh-release
1
0
Fork 1
mirror of https://github.com/softprops/action-gh-release.git synced 2025-06-27 22:06:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: fix file closing issue (#629)

Browse source 
* fix: handle file closing gracefully

* fix: failing test on Windows

* format code using npm run fmt
This commit is contained in:
Roland Dominik Szilágyi 2025-06-10 23:12:05 +02:00 • committed by GitHub
parent d5382d3e6f
commit 07a2257003
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
dist/index.js vendored
View file

File diff suppressed because one or more lines are too long

5
src/github.ts
View file

@ -180,6 +180,7 @@ export const upload = async (
endpoint.searchParams.append("name", name); endpoint.searchParams.append("name", name);
const fh = await open(path); const fh = await open(path);
try { try {
const stream = fh.readableWebStream();
const resp = await github.request({ const resp = await github.request({
method: "POST", method: "POST",
url: endpoint.toString(), url: endpoint.toString(),
@ -188,7 +189,7 @@ export const upload = async (
"content-type": mime, "content-type": mime,
authorization: `token ${config.github_token}`, authorization: `token ${config.github_token}`,
}, },
data: fh.readableWebStream(), data: stream,
}); });
const json = resp.data; const json = resp.data;
if (resp.status !== 201) { if (resp.status !== 201) {
@ -201,7 +202,7 @@ export const upload = async (
console.log(`✅ Uploaded ${name}`); console.log(`✅ Uploaded ${name}`);
return json; return json;
} finally { } finally {
await fh.close(); await fh.close().catch(() => {});
} }
}; };

5
src/util.ts
View file

@ -91,7 +91,10 @@ const parseMakeLatest = (
export const paths = (patterns: string[]): string[] => { export const paths = (patterns: string[]): string[] => {
return patterns.reduce((acc: string[], pattern: string): string[] => { return patterns.reduce((acc: string[], pattern: string): string[] => {
return acc.concat( return acc.concat(
glob.sync(pattern).filter((path) => statSync(path).isFile()), glob
.sync(pattern)
.filter((path) => statSync(path).isFile())
.map((path) => path.replace(/\\/g, "/")),
); );
}, []); }, []);
}; };