massivebox/siyuan-jsdraw-plugin
massivebox/siyuan-jsdraw-plugin
2
1
Fork 0
forked from mirrors/plugin-sample-vite-svelte
Code Issues 4 Pull requests Projects 3 Releases 6 Packages Wiki Activity Actions

Remove internal FileID stuff #1

New issue
Closed
opened 2025-04-01 21:58:58 +00:00 by massivebox · 2 comments
massivebox commented 2025-04-01 21:58:58 +00:00
Owner
Copy link

The current fileID system is unneeded, and prevents the easy extension of the plugin to all SVG files. It should therefore be dropped.

The current fileID system is unneeded, and prevents the easy extension of the plugin to all SVG files. It should therefore be dropped.
massivebox added this to the SVGs First and Foremost project 2025-04-01 21:58:58 +00:00
massivebox commented 2025-04-02 18:19:36 +00:00
Author
Owner
Copy link

Initially addressed in a2503d5def
The removal of fileID will happen in a while, after a system to update all blocks is created, so that the transaction can be seamless.

Initially addressed in https://git.massive.box/massivebox/siyuan-jsdraw-plugin/commit/a2503d5defd00f5939778b0660ca1bd227a13ede The removal of fileID will happen in a while, after a system to update all blocks is created, so that the transaction can be seamless.
massivebox commented 2025-04-05 09:09:04 +00:00
Author
Owner
Copy link

After much consideration following the discovery of file sync issues in #4 (comment), the FileID system is being reinstated and will remain indefinitely.

This change comes because:

  • SiYuan seems to only display images in the ./data/assets directory, so supporting other directories is not needed
  • We now need a filename-based system to avoid sync inconsistencies. Having FileIDs allows us to use a common format, like ./data/assets/FILE_ID+EDIT_ID.svg, where EDIT_ID is an unique ID that changes every time the Save button is clicked.
After much consideration following the discovery of file sync issues in https://git.massive.box/massivebox/siyuan-jsdraw-plugin/issues/4#issuecomment-32, the FileID system is being reinstated and will remain indefinitely. This change comes because: - SiYuan seems to only display images in the `./data/assets` directory, so supporting other directories is not needed - We now need a filename-based system to avoid sync inconsistencies. Having FileIDs allows us to use a common format, like `./data/assets/FILE_ID+EDIT_ID.svg`, where `EDIT_ID` is an unique ID that changes every time the Save button is clicked.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.3.0
v0.2.2
v0.2.1
v0.2.0
v0.1.1
v0.1.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
SVGs First and Foremost
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: massivebox/siyuan-jsdraw-plugin#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?