massivebox/action-gh-release
1
0
Fork 0
forked from mirrors/action-gh-release
Code Pull requests Activity Actions

feat: add support for release assets with multiple spaces within the name (#518)

Browse source 
* extracted the asset name alignment to utils, added unit tests

* fixed formatting issues
This commit is contained in:
Eugen Dukhin 2024-11-11 21:12:02 +01:00 • committed by GitHub
parent b019a5bbb6
commit 98daca21d1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 23 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/github.ts
View file

@ -1,5 +1,5 @@
import { GitHub } from "@actions/github/lib/utils";
import { Config, isTag, releaseBody } from "./util";
import { Config, isTag, releaseBody, alignAssetName } from "./util";
import { statSync, readFileSync } from "fs";
import { getType } from "mime";
import { basename } from "path";
@ -166,7 +166,7 @@ export const upload = async (
// note: GitHub renames asset filenames that have special characters, non-alphanumeric characters, and leading or trailing periods. The "List release assets" endpoint lists the renamed filenames.
// due to this renaming we need to be mindful when we compare the file name we're uploading with a name github may already have rewritten for logical comparison
// see https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28#upload-a-release-asset
({ name: currentName }) => currentName == name.replace(" ", "."),
({ name: currentName }) => currentName == alignAssetName(name),
);
if (currentAsset) {
console.log(`♻️ Deleting previously uploaded asset ${name}...`);